This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
Change GracefulStop into a RO channel #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently the CLI tooling does write directly to the chan. Coming to think of it, other people may do that as well, since it's an exported property. It may be a nice change for the next major version then (given that I also fix the test)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate never writes to the GracefulStop channel, so why not guarantee that by turning the chan into a ReadOnly channel?
In my case I already had such a channel available which happened to be RO, so for me it wasn't just a nice to have, but sort of a necessity :)
I believe this change does not break BC.